Skip to content

[ROCm][CI] fix test_common.py#48676

Merged
AndreasKaratzas merged 2 commits into
vllm-project:mainfrom
charlifu:amd/fix_test_common.py
Jul 15, 2026
Merged

[ROCm][CI] fix test_common.py#48676
AndreasKaratzas merged 2 commits into
vllm-project:mainfrom
charlifu:amd/fix_test_common.py

Conversation

@charlifu

@charlifu charlifu commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Cause

Newer Transformers requires a tokenizer when generate() uses stop strings. That can come from:

Explicit stop_strings= in the call, or
The model’s generation_config.json
naver-hyperclovax/HyperCLOVAX-SEED-Think-14B (used in test_common.py) has this in its generation config:

"stop_strings": ["<|endofturn|>", "<|stop|>"]
HfRunner in tests/conftest.py was calling:

self.model.generate(**inputs, ...)
without tokenizer=, so Transformers raised that ValueError.

Fix
HfRunner now passes the tokenizer by default in all three model.generate() paths:

generate_kwargs = dict(kwargs)
generate_kwargs.setdefault("tokenizer", self.tokenizer)
self.model.generate(..., **generate_kwargs)

Callers can still override by passing tokenizer= explicitly (as vlm_utils/core.py already does).

Signed-off-by: charlifu <charlifu@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the rocm Related to AMD ROCm label Jul 15, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Jul 15, 2026
@charlifu

Copy link
Copy Markdown
Contributor Author

@AndreasKaratzas

@AndreasKaratzas AndreasKaratzas added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 15, 2026
@AndreasKaratzas AndreasKaratzas enabled auto-merge (squash) July 15, 2026 04:51
@AndreasKaratzas AndreasKaratzas merged commit adce068 into vllm-project:main Jul 15, 2026
92 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants